feat(Table,misc): rewrite column management demo, remove old dnd examples #11295
+523
−1,044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11295.surge.sh A11y report: https://patternfly-react-pr-11295-a11y.surge.sh |
tlabaj
requested review from
a team,
wise-king-sullyman and
tlabaj
and removed request for
a team
|
@kmcfaul can you open an issue to track the DragDropSort bug you mention above? |
|
Opened #11312 |
kmcfaul
force-pushed
the
dep-dnd-removal
branch
from
2fdd4ed to
547121b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11190.
Also slightly touches up the basic column management demo as the changes to Modal are the same.
There is an issue with
DragDropSortI've noticed but haven't yet debugged, that the DataListItems it creates internally are for some reason duplicating theDataListItemControlcomponent for theDataListCheck, giving it extra padding. I'm not sure why this is happening, as it doesn't occur in theDragDropSortDataList example even with the same content code structure.